cameri / nostream / 41228990797

77%

push

github

ci(deploy): retry the website deploy step on a transient Cloudflare failure (#1005)

## What

The website deploy step now goes through
`.github/scripts/deploy-with-retry.sh` in both
`deploy-website-preview.yml` and `deploy-website.yml`. The build is
untouched; only the `wrangler deploy` call is wrapped.

[Run
40103130697](https://github.com/cameri/nostream/actions/runs/40103130697)
failed at `Deploy the preview worker` with:

```
✘ [ERROR] A request to the Cloudflare API (/accounts/…/workers/scripts/nostream-web-pr-969/assets-upload-session) failed.
  An unknown error has occurred. [code: 10013]
```

The build had already succeeded, the run one minute earlier on the same
branch passed, and the failing commit only deleted five lines from
`Peering.astro`. One transient failure in roughly five runs is enough to
make the job lie about the change it is testing.

## Behaviour

- **3 attempts**, 10 s then 30 s of backoff — about a minute of added
time in the worst case.
- **Per-attempt timeout** (180 s, `DEPLOY_ATTEMPT_TIMEOUT`) plus
`timeout-minutes: 12` on the step, so a stalled upload cannot hold the
job.
- **Only transient signals retry**: `code: 10013`, an HTTP 5xx, a
connection reset, and an expired attempt timeout. An authentication
failure, a missing environment or a wrangler validation error fails on
the first attempt and is reported as `::error::`.
- **Every retry is announced** with `::warning::` naming the attempt and
the reason, so the flake rate stays visible in the Actions UI rather
than disappearing behind a green job.

The command is passed in as arguments, so each workflow keeps its own
invocation — `npx wrangler` for the preview, `pnpm exec wrangler … --var
CANONICAL_HOST:"$CANONICAL_HOST"` for production — and its quoting.

## Tests

`test/unit/scripts/deploy-with-retry.spec.ts` runs the real script
against a stub `wrangler` on `PATH` that records every invocation:

```
deploy-with-retry.sh
  ✔ retries a Cloudflare 10013 failure and names... (continued)

4337 of 6162 branches covered (70.38%)

Branch coverage included in aggregate %.

9419 of 11759 relevant lines covered (80.1%)

778.5 hits per line