savonrb / savon / 41225093303

100%

master: 98%

push

github

Skip reserved xml prefixes when reusing WSDL namespace identifiers

Since Builder#use_namespace reuses the WSDL's prefix for a type namespace, a schema whose targetNamespace is the WSDL root's default namespace produced an envelope declaring xmlns:xmlns, because Wasabi stores the default namespace under the bare key 'xmlns'. Prefixes starting with 'xml' are reserved by the XML Namespaces spec, so such an envelope is not namespace-well-formed and a strict parse reports errors. The lookup now skips xml-prefixed keys (case-insensitive) and takes another prefix the WSDL declares for the same URI when one exists, falling back to ins0, ins1, ... as before.

4 of 4 new or added lines in 1 file covered. (100.0%)

1209 of 1210 relevant lines covered (99.92%)

191.33 hits per line