IJHack / QtPass / 41191630236

93%

push

github

Secret fields: one pattern per list; say it errs on the hidden side (#2093)

* Secret fields: one pattern per list; say it errs on the hidden side

Henk's review of #2092 (pedantic points):

- isSecretFieldName() built a regular expression per word for every
  field of every entry shown. The words are now one pattern, compiled
  once per list (thread_local, rebuilt when the list changes).
- hidesAsSecret() lives in the anonymous namespace urlButton() is in,
  not a second one right after it.
- The words' tooltip says the default set errs on the hidden side
  ("Public key", "Password hint" are hidden too) and how to show them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Secret fields: match word by word when the list is too large for one pattern

CodeRabbit on #2093: a list long enough to pass PCRE2's size limit made
the combined pattern invalid, which matches nothing, so every configured
secret field would have shown in plain view. The escaped words are kept
with the pattern; when it does not compile, each word is matched on its
own. The rebuild no longer retries an invalid pattern on every call
either: it is rebuilt when the list changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* tst_filecontent: don't require the large list to break one pattern

CodeRabbit on #2093: whether 40000 words fit one PCRE2 pattern depends
on the build's LINK_SIZE; a build with a larger one compiles it, and the
precondition then failed although matching was right. The test now only
notes which path the build takes; the matching assertions, the same
either way, run on every build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf4... (continued)

19 of 19 new or added lines in 1 file covered. (100.0%)

9935 of 10722 relevant lines covered (92.66%)

400.57 hits per line