solidjs / solid / 41137970951

78%

main: 89%

push

github

fix(web): let AssetManifest carry `_base` and other metadata strings (#4502) (#4506)

`AssetManifest` was `Record<string, Entry> & { _base?: string }`. `_base`
also falls under the string index signature, so it had to be an entry and a
manifest literal that set `_base` failed to type-check; it only went
unnoticed through `JSON.parse` or a cast.

The index signature now carries `Entry | string | undefined` with `_base`
declared alongside (`undefined` is required for the optional `_base` under
strictNullChecks). Other `_`-prefixed metadata such as the vite plugin's
`_entry` fit the same signature. A keyed read is an entry once narrowed.
Both declarations change in lockstep (server.ts and the client entry's
server-mock.ts, held mutually assignable by server-mock.type-tests.ts).
The vite plugin's current `ViteManifest` stays assignable, and so does the
index-signature shape it can move to next.

The server renderer narrows where it reads entries: `registerEntryAssets`
skips non-object values (it threw on an `undefined` value the type now
admits) and `resolveAssets` answers null for a metadata key (it threw in
`joinAssetPath` on a string). Server-only; client bundles 0 B.

No signals rule (F-n / D-n) governs this: it is a type and asset-manifest
contract fix with no reactive semantics.


Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.68 hits per line