solidjs / solid / 41098368207

78%

main: 89%

push

github

fix(signals): a verdict reader born into a hold joins it at its re-pass (#4467) (#4471)

* fix(signals): a verdict reader born into a hold joins it at its re-pass (#4467)

A memo that read an action's held `x` is born held. When it mounts a
`Loading` and calls the function the fallback returned, `latest(x)` runs
in the memo's own pass and leaves CONFIG_VERDICT on it (D-25: the posture
outlives the pass). At the content's landing the memo re-runs, still born
into the hold and never committed, but recompute's held re-pass arm
skipped the join for any verdict reader. The flush had no transaction, so
the boundary the re-run mounted was not the hold's: it caught its own
born-held tree (`freshHook(el, !mount && flushTransaction)`) and showed
the fallback. The output then re-derived to the landed content, the memo
re-ran, mounted another boundary, and so on without end.

A pass born into its hold's world is the hold's own work and reads
plainly whatever it asked before (D-25, D-27 #4341; `frameRead` already
exempts it through `bornInto`). The held re-pass now joins it too, so the
boundary it mounts is the hold's and appears at its commit (D-13): the
screen goes from the held frame straight to "1:C". The check sits behind
`observeFlightHook`, so bundles without the verdict engine are unchanged.

Size: +29 B minified on the isPending/latest scenarios, 0 B elsewhere.
page: compiled live server components re-recorded 42.73 -> 42.76 KB.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): re-measure the born-held verdict join over next @ 749b0d7

Live server components 38.85 -> 38.91 KB (117,544; Size-Exception in the PR
body), compiled live 42.79 -> 42.83 KB (125,684); isPending/latest and
live + router re-record minified with caps unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

-... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.94 hits per line