nats-io / nats.js / 41072242263
90%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
41072242263

push

github

web-flow 
fix(jetstream): direct batch get on request many, per reply timeout (#473)

* fix(jetstream): direct batch get on request many, per reply timeout

getBatch and getLastMessagesFor now use requestMany. a strategy ends
the request on end of batch, no results or a single reply, and fails
it on any other status.

timeout (new option, defaults to the jetstream client timeout) applies
to each reply: the first, and every one after it. a batch that keeps
flowing is never cut short; one that stalls fails with a TimeoutError.
the timeout is not sent to the server.

fixes:
- a batch that stalled after the first reply hung forever, the
  subscription timeout (a fixed 5s) only covered the first reply.
- no results also pushed an error after ending the batch.
- a single reply was pushed after the stop, so it could be lost; the
  single reply check never matched (headers.get returns "" when the
  header is missing).
- stopping from the callback could deliver messages after done; done
  is now the last callback and nothing is delivered after a stop.
- a connection close mid batch now fails the batch instead of hanging.
- getBatch modified the caller's options.
- DirectConsumer consume (experimental) retried in a tight loop after
  an error or on an empty stream; it now waits 2.5s after a pull that
  failed or delivered nothing. it no longer adds a close handler per
  pull, and stops if the request can't be made.

change: a 503 (no jetstream, no stream, or direct get not enabled)
now fails with NoRespondersError, previously JetStreamStatusError
(503). DirectConsumer reports it as code 503.

* fix(jetstream): direct consumer stop doesn't leak a sleep

- direct consumer checks for stop before sleeping: a stop during a
  pull started a 2.5s sleep nothing cancelled
- test responder (slowDirect) cancels its pending delays when the
  connection closes, and stops instead of starting another

* review comment - added test for gap
Source Files on build 41072242263
Detailed source file information is not available for this build.