bootstrapworld / codemirror-blocks / 41068659429

96%

Build Type

push

github

Committed by schanzer

Commit Message

perf(ast): print each node's layout once per print, not once per use

The pretty-printer builds both the one-line and the broken layout of a list
from the same children, and asks each child for its Doc again every time, so a
node nested n deep was printed 2^n times. big-expression.rkt (537 bytes) took
about 4.3 seconds; building its Doc now takes 1 ms. While one print is under
way each node makes its Doc once and shares it; nothing is kept afterwards,
because fakeAstEdits mutates cloned nodes between prints.

The printed text is byte-identical for every example program. big-expression.rkt
is no longer skipped in lifecycle-test, and a new check that it prints in under
a second fails (4.3 s) without the change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Coverage Stats

1772 of 2387 branches covered (74.24%)

12 of 12 new or added lines in 1 file covered. (100.0%)

55 existing lines in 7 files now uncovered.

3168 of 3753 relevant lines covered (84.41%)

4585.78 hits per line