solidjs / solid / 41061774344

78%

main: 89%

push

github

fix(signals): createOptimisticStore(fn) passes an upstream memo's error to its readers (#4437) (#4457)

* fix(signals): createOptimisticStore(fn) delivers an upstream memo's error (#4437)

A derived optimistic store built its family by hand and left out the two
links `createProjection` sets: the family's status hook (`fam.st`) and the
derive's back-pointer (`node.fam`). A failed memo the derive reads reaches
the derive by status propagation, not by a re-run of its pass, so without
them the leaves' readers never learned the error (F-12). The store now
builds its family through `createProjectionInternal`, with an `opt` flag
and an optional derive, so both forms share one constructor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): record #4437's sizes over next @ 7135a77a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): a derived store hands one upstream error to its readers once

errorFamily re-ran every live reader of the family on each errored pass of
the derive. A second pass meeting the same upstream error object - a held
error's commit dirtying the derive under an optimistic store's action guess
(the regression #4457 review found), or a reader's pull retrying an errored
async derive beside an isPending probe (pre-existing in createStore(fn)) -
re-ran readers already showing that error, so an effect's error arm ran
twice (D-41: the arm runs once, at the reveal). A reader already errored
with the very error being handed off is now skipped, as core
propagateStatus skips one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.81 hits per line