solidjs / solid / 41060700739

78%

main: 89%

push

github

fix(signals): a verdict reader born into a hold reads it whichever flush runs it (#4426) (#4454)

* fix(signals): a verdict reader born into a hold reads its value in any transaction's flush (#4426)

`read` asked two deciders whether the pass was born into the hold, with
two different holds. `frameRead` asked about the node's hold
(`bornInto(c, txOf(el))`) and joined the pass, and `stagedScreen` then
asked about the flush's transaction (`bornInto(c, flushTransaction)`).
For a verdict reader born into T and run by another transaction's flush,
the second answer was no, so it was served the committed value. That is
the screen the first answer had just ruled it does not have (D-25: the
hold's own work, born in its world, reads plainly; D-27 / A29: a node
born into a hold has no screen).

`stagedScreen` now takes the node. A held node (not a lane's) that `read`
or `serve` brings here is one `frameRead` found the reader born into,
because `frameRead` served every other one the screen. So it answers "no
screen" for it, as it already did when the flush's transaction was that
hold.

Fixes #4426

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): record #4426's cost on the live server-component pages

Measured locally (linux) over next @ 7135a77a. On page: live server
components (a frozen floor): 38,795 B brotli / 117,251 B minified, +24 B
minified, so the cap goes 38.76 -> 38.81 KB and floor-caps.json's
recorded minified 117,227 -> 117,251. On page: compiled live server
components: 42,689 / 125,398, so the cap goes 42.67 -> 42.70 KB and the
recorded minified 125,374 -> 125,398. Caps are at measured + 10 B
rounded up to 0.01 KB. Every other scenario passes the gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.76 hits per line