supabase / supabase-swift / 41059963376

96%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(auth): simplify Phase 2 session internals (#1644)

* refactor(auth)!: move the refresh single-flight into SessionStore with cooldown and refresh window

SessionStore now owns refresh deduplication, so every client that shares a store shares one refresh per token. A cancelled waiter throws CancellationError at once while the shared refresh still commits. A failed token throws its cached error for 60 seconds, and a sixth refresh in 30 seconds throws excessiveRefresh. A signedOut commit cancels running refreshes.

BREAKING CHANGE: refreshSession and an expired session() can throw a cached error or AuthError.Kind.excessiveRefresh without a request, and callers of a refresh that signOut cancels get CancellationError.

Fixes SDK-2059

* fix(auth): age out refresh throttles when the clock moves backward

The refresh failure cooldown and the refresh window treated a negative
interval as recent, so after the wall clock moved back one failure
blocked its token, and five refreshes blocked every refresh, until the
clock caught up. Both now treat a negative interval as elapsed.

A refresh cancelled by sign-out now throws CancellationError and caches
nothing, whatever error the request ends with. A transport can report
the cancel as URLError.cancelled from the response body, which became
AuthError(.transport) and was cached for the signed-out token.

Add "cooldown" to the spell-check dictionary.

* test(auth): import FoundationNetworking for URLError on Linux

* feat(auth)!: sign out only when a rejected refresh leaves an expired session

A failed refresh keeps the session unless the server rejected the refresh
token and the held session is expired at the store's injected time. A
proactive refresh that the server rejects keeps the session until it
expires. A cached rejection signs out once the held session has expired.

BREAKING CHANGE: refreshSession() can throw .sessionInvalidated while the
session stays signed in. React to the .signedOut event to show s... (continued)

Coverage Stats

18 of 19 new or added lines in 5 files covered. (94.74%)

2 existing lines in 1 file now uncovered.

13633 of 14498 relevant lines covered (94.03%)

561943.18 hits per line