OpenCHAMI / ochami / 40956982994

93%

push

github

fix(smd): document iface commands and accept multiple network pairs (#225)

* docs(smd): document iface add and delete in ochami-smd(1)

The iface section of ochami-smd(1) only described "get". Add entries for
"add" and "delete", following the compep and rfe sections: their forms,
the payload input options, --all and --no-confirm for delete, and the
rule that delete only uses each payload item's ID (blank or path-like IDs
are a usage error, and no ID is derived from MACAddress).

Fixes #206

Signed-off-by: anyingiit <49945850+anyingiit@users.noreply.github.com>

* fix(smd): accept multiple network pairs when adding an interface

Accept at least three positional arguments so iface add can consume every
network,IPv4 pair advertised by its help text and examples. Keep all pairs
on one Ethernet interface in the request rather than rejecting commands
that specify more than one address.

Reject pairs without a comma or network name before indexing their fields
to report a usage error instead of panicking. Preserve IPv4 validation and
validate every pair before sending the interface to SMD.

Update the man page to describe repeated pair arguments. Add command tests
that verify the complete multi-address request and reject malformed pairs,
including invalid later pairs, without sending a request. Follow the
test/organize conventions for test names, files, comments, and runtimes.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

* docs(smd): clarify iface payload shape and ignored arguments

State that iface add and delete payloads must be an array of
EthernetInterface objects, even for a single interface. Both commands
unmarshal -d data directly into a slice, so a bare object is rejected,
and the data structure example already showed an array while calling
it a single EthernetInterface.

Correct the delete validation rule to cover only the IDs used to select
interfaces. With --all or -d, positional arguments are ignored with a
warnin... (continued)

5 of 5 new or added lines in 1 file covered. (100.0%)

13060 of 13998 relevant lines covered (93.3%)

711.87 hits per line