• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zalando-incubator / kube-ingress-aws-controller / 40927242872
81%

Build:
DEFAULT BRANCH: master
Ran 29 Oct 2026 06:11PM UTC
Jobs 1
Files 27
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

29 Oct 2026 06:03PM UTC coverage: 71.89% (+0.4%) from 71.451%
40927242872

push

github

web-flow
feature: support ARC zonal shift on load balancers (#822)

Closes #821

## Motivation

ARC zonal shift and zonal autoshift can move traffic away from an
impaired AZ, but only once `zonal_shift.config.enabled` is set on the
load balancer. The controller manages the load balancer attributes, so
the setting needs to come from the controller.

## Changes

- [x] New flag `--zonal-shift-enabled` (default `false`) that sets
`zonal_shift.config.enabled` on Application and Network Load Balancers
- [x] The attribute is always set explicitly, as with
`load_balancing.cross_zone.enabled` after #682, so turning the flag off
also applies to existing load balancers
- [x] Unit tests for ALB and NLB (enabled and default), and for the
attribute's position after the access log attributes
- [x] Golden files regenerated with `go test -run
TestResourceConversionOneToOne . -update`; the four fixtures that test
doesn't compare (`ingress_alb_ipv6_tg`, `ingress_nlb_ipv6_tg`,
`ingress_rg_shared_alb`, `ingress_rg_shared_nlb`) updated by hand to
stay consistent
- [x] Update README (features, load balancer types table, zone aware
traffic, upgrade notes)
- [x] Bump minor version

## Breaking change

Previously this attribute was not set. After the upgrade, existing load
balancers get one in-place stack update that sets
`zonal_shift.config.enabled=false`. Changing `LoadBalancerAttributes`
doesn't replace the load balancer ([CloudFormation
reference](https://docs.aws.amazon.com/AWSCloudFormation/latest/TemplateReference/aws-properties-elasticloadbalancingv2-loadbalancer-loadbalancerattribute.html)).
If zonal shift was enabled outside the controller, it gets disabled
unless `--zonal-shift-enabled` is set. This is described in the README
upgrade notes.

## Testing

```
make lint    # clean
make test    # all pass
```

I also checked the CloudFormation behaviour in a test account
(us-east-1). The stack had one internal ALB and one internal NLB, using
the same attribute lists the controll... (continued)

10 of 18 new or added lines in 3 files covered. (55.56%)

2757 of 3835 relevant lines covered (71.89%)

11.82 hits per line

Uncovered Changes

Lines Coverage ∆ File
6
32.31
-0.28% aws/adapter.go
2
42.64
0.09% controller.go
Jobs
ID Job ID Ran Files Coverage
1 40927242872.1 29 Oct 2026 06:11PM UTC 27
71.89
GitHub Action Run
Source Files on build 40927242872
  • Tree
  • List 27
  • Changed 4
  • Source Changed 0
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 8dbcc408 on github
  • Prev Build on master (#37440598412)
  • Next Build on master (#40956720984)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc