zhmcclient / python-zhmcclient / test-5011

80%

Build Type

push

github

Committed by web-flow

Commit Message

Support additional_properties in list(), list_permitted_XXX(); Fixes (#2307)

* Support for additional_properties in list() for all resource types; Fixes

Details:

* Reworked the _list_with_operation() and _list_with_parent_array() methods
  that are used by the resource-type specific implementations of the list()
  method, to support the additional_properties parameter for all resource
  types and not just for those where the HMC supports the
  additional-properties query parameter on the list operation.

  This required adding a supports_additional_properties flag to the manager
  objects, which indicates whether the latest (!) HMC version supports the
  'additional-properties' query parameter on the corresponding List operation
  (consistent with the already existing supports_properties flag).

  The new approach is based on the supports_properties and
  supports_additional_properties flags in the manager object and tries the
  most efficient approach first and then falls back to less efficient but
  more broadly available approaches. The details of the approaches are
  described in the new "Listing resources" section of the documentation.

* Added a new _list_singleton() method for listing singleton objects that is
  also optimized in that it considers the resource cache for auto-updated
  resources. The only resurce type this is used for is the Console. This was
  done mostly for consistency with the other operations, but as a side effect
  it also takes benefit from the auto-updating of the console.

* Added the new supports_additional_properties=True flag for all resource
  types that support the 'additional-properties' query parm as of HMC 2.17.0:
  - activation_profile (only for profile type 'image')
  - adapter
  - certificates
  - partition_link
  - partition
  - sso_server_definition
  - storage_volume
  - virtual_switch
  - virtual_tape_resource

* Fixed the missing supports_properties=True flag for the following resource
  types:
  - ce... (continued)

Coverage Stats

2252 of 3308 branches covered (68.08%)

Branch coverage included in aggregate %.

197 of 271 new or added lines in 33 files covered. (72.69%)

1 existing line in 1 file now uncovered.

11482 of 13951 relevant lines covered (82.3%)

6.58 hits per line