solidjs / solid / 40817312993

78%

main: 89%

push

github

fix(signals): a held recovery keeps its shown error for frame and verdict readers (#4396)

* fix(signals): a held recovery keeps its shown error for frame and verdict readers

An errored sync memo that recovers in a staged pass cleared its error
status without keeping the error as the shown one. A frame or verdict
reader served the committed value then read `undefined`: under an open
action, `createErrorBoundary(() => "X" + latest(s) + m())` showed
`X1undefined` while the screen still owed the error (D-39, D-41, F-7).

The staged recovery now keeps the error it replaces as `_shownError`
until its commit. A frame reader served the committed value, and a
verdict reader served the screen, read that error, as an untracked read
already did. At the landing, an errored stale reader whose error's source
is no longer errored re-derives (the #3945 skip still holds for a source
that is). Offsets: two trailing `undefined` arguments dropped and
`_shownError` reset to `null`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): ledger for the held recovery's shown error (+22..+43 B minified), over next @ 1b32ff2e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(signals): offset the held recovery's floor bytes

Four perf-neutral rewrites in the floors' own code pay for most of the
fix. `recompute` now captures its outgoing error and pending sources with
`&&` instead of `? : undefined`. `notifyStatus` and `propagateStatus` do
the same for the pending source. Every reader of those values is
truthy-guarded, and `settleErroredDependents` now also skips a null
error, which it never needed to walk. The core floor goes from +36 B to
+7 B minified over next, the frameworks' floors from +35 B to +6 B, and
the live server-components floor ends at 115,182 B. The ledger is
re-recorded against next @ 1... (continued)

790 of 1084 branches covered (72.88%)

Branch coverage included in aggregate %.

1125 of 1355 relevant lines covered (83.03%)

29.98 hits per line