solidjs / solid / 40802360295

78%

main: 89%

push

github

test(web): pin #4372, a rejected streamed fragment emptying a text-only region (#4389)

* fix(web): a hydrating hole holding a raw string re-claims its region (#4374)

A `<Loading>` with a bare-string fallback, the sole content of a
markerless parent, leaves the hole's `current` as that string after the
root pass. `reclaimRegion` bailed for non-node currents, so after the
streamed `$df` swap the content pass reconciled against the stale string:
the server's text stayed beside a fresh copy (a nested Errored's fallback
rendered twice), or text after an element moved or was replaced instead
of adopted. While hydrating, a disconnected-or-primitive `current` now
re-claims the region, as it does when the nodes it tracks are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(web): a sole text child's update inserts when the document removed its node (#4372)

An Errored outside a streamed Loading whose fragment rejects: the client
hydrated the shell, so the root insert tracked the claimed fallback's
text ("[LOAD]") as a sole text child. The fragment's swap replaced that
node, and the rejected fragment's fresh render cleared what the swap put
in, so the Errored's fallback text was written to `parent.firstChild`,
which was null: TypeError, REACTIVITY_HALTED, an empty <main>. The text
fast path now needs that node to exist; with none, the value is inserted
like a first one, as the element path already does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(solid): a rejected fragment's clear gives an emptied region its text node back (#4372)

Moves the #4372 fix off `insertExpression`'s hot text path, which every
app ships, to the cold path that breaks its assumption. A streamed
Loading whose fallback an insert claimed as its sole text child: the
fragment's swap takes that text node with ... (continued)

790 of 1084 branches covered (72.88%)

Branch coverage included in aggregate %.

1125 of 1355 relevant lines covered (83.03%)

29.94 hits per line