Chia-Network / chia-blockchain / 40722267222

90%

Build Type

push

github

Committed by web-flow

Commit Message

Fix fee estimates that are 1,000 times too small (#21533)

* Fix fee estimates that are 1,000 times too small

The tracker stores mojos per 1,000 cost, and the publisher already divides by 1,000 to report mojos per cost. parse() divided a second time, so a stored rate of 5,000 was published as 0.005. Return the stored unit from parse() and keep that single division in the publisher.

A stored 5,000 now publishes as 5.0. The steady-rate test checks that blocks paying 2 mojos per cost are quoted at about 2.

* Test the fee quote the command line and desktop app receive

get_fee_estimate now checks a stored rate of 5,000. A cost of 1, which chia show -f uses, must come back as 5. send_xch_transaction, which the desktop fee box uses, must come back as 5 times 9,401,710. A rate under 1 mojo per cost still becomes 0 at cost 1.

Name the 1,000-cost storage scale once, and use it where the tracker stores a rate and where the publisher converts it. The failure-bucket test follows the edge the tracker records and expects one bucket above the failure. The clamp at the first bucket is unchanged.

* Let the fee quote test satisfy the type check

The checker rejected a loose function assigned over get_blockchain_state, and the ignore comment named the wrong error. The test now uses a small subclass whose replacement has the same arguments and result. The quoted amounts are unchanged.

* Name the fee cap unit and lock the desktop send amount

The cap is still 40,000,000. The note now says that figure is mojos per 1,000 cost. The unit test expects 47,008,550 mojos for a desktop send at 5 per cost.

Coverage Stats

20237 of 25170 branches covered (80.4%)

Branch coverage included in aggregate %.

79 of 80 new or added lines in 5 files covered. (98.75%)

23 existing lines in 7 files now uncovered.

119241 of 129002 relevant lines covered (92.43%)

1.85 hits per line