microlinkhq / keyvhq / 40743697818

97%

push

github

fix: delete expired keys before get and iteration continue (#291)

* test: await the call in every 'returns a Promise' test

The set, get, delete and has 'returns a Promise' tests checked the type
and dropped the promise. On stores with real I/O the un-awaited
set('foo', 'bar') could land after a later test's set('foo', 'bar', ttl)
and overwrite it with a key that never expires: the sqlite suite opens a
connection per store with a 30s busy timeout. A reproduction with the
real sqlite store and the suite's order left the TTL key live in 5 of 40
runs with the write pending and 0 of 40 with it awaited. This is the
second cause of the '.set(key, value, ttl) sets a value that expires'
flake that #287 did not cover; it still failed on #290.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test: fail if a returned promise is still pending

The 'returns a Promise' tests stayed green when the await was removed, so a
floating set could still land after a later TTL write. Assert that the
promise has settled before the test ends.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: finish expiry deletion before returning

get and iterator started a delete for an expired key and continued
without waiting, so a slow delete could remove a newer write of the
same key. iterator also passed the stored key back through delete,
which prefixed a namespace a second time and left the real key in place.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: note why iterator strips the prefix before delete

The stored key already includes the namespace, and delete() adds it again.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: remove the full namespace prefix before expiry deletion

A namespace that contains a colon was only stripped at the first colon, so cleanup deleted a different key.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(sql): page the iterator by key instead of offset

Deleting an expired row during a scan shifted later rows... (continued)

353 of 374 branches covered (94.39%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 2 files covered. (100.0%)

1019 of 1035 relevant lines covered (98.45%)

67.2 hits per line