microlinkhq / keyvhq / 40739756220

97%

push

github

fix(redis): keep scanning until the cursor returns to 0 (#288)

* test(redis): iterate a namespace whose SCAN pages come back empty

Seeds 1000 keys outside the namespace and 5 inside it, so the default
SCAN COUNT returns empty pages with a non-zero cursor before reaching
the namespace keys. On master the iterator yields 0 of the 5 entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(redis): keep scanning until the cursor returns to 0

The iterator returned as soon as a SCAN page had no keys. Redis only
signals the end of a scan with cursor 0; a page may be empty while
the cursor is still non-zero, which is common when the namespace
matches few keys. The iterator stopped early and yielded a partial
or empty result.

Iterate with a loop that ends on cursor '0' and skips the MGET for
empty pages. The loop also replaces the recursive generator, so a
long scan no longer stacks one delegating generator per page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(redis): escape namespace globs and skip missing scan keys

SCAN MATCH treats * ? [ and \ as globs, so a namespace such as [ab]
never yielded or cleared its own keys, and a* cleared neighboring
namespaces. Escape those characters in the shared match pattern.

MGET returns null when a key disappears between SCAN and MGET. Yielding
that null makes Keyv throw while reading expires. Skip those keys.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(redis): guard the empty SCAN page before MGET

The empty-page branch wrapped the fetch and yield. A continue keeps
that path at the top of the loop.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

344 of 368 branches covered (93.48%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 1 file covered. (100.0%)

1021 of 1039 relevant lines covered (98.27%)

65.91 hits per line