solidjs / solid / 40702003916

78%

main: 89%

Build Type

push

github

Committed by web-flow

Commit Message

fix(solid): Show's narrowed accessor reads the screen during a closing hold (#4354) (#4359)

Non-keyed Show judged staleness from a `shown` flag the selection memo set
on every run. When a hold kept the branch on screen, the selection had
already re-run in the held world and set the flag false, so an unrelated
write that re-ran an on-screen binding threw the stale-value error and
halted. The guard now reads `condition()` tracked, as Match's guard does:
the reading binding is a frame reader and sees the screen's truthiness,
while a read after unmount still sees the committed falsy and throws.


Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Co-authored-by: Claude <noreply@anthropic.com>

Coverage Stats

790 of 1079 branches covered (73.22%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

85 existing lines in 1 file now uncovered.

1122 of 1352 relevant lines covered (82.99%)

29.0 hits per line