solidjs / solid / 40701984953

78%

main: 89%

push

github

fix(hydration): a hydrated Errored's fallback keeps lazily created content from claiming (#4357)

* fix(hydration): a hydrated Errored's fallback keeps lazily created content from claiming (#4348)

A hydrated `<Errored>` that shows the server's fallback ran its content in a
claim window over no owner, but the window only covered the content's own
run. Children the content resolves lazily — a context provider's, a function
child, a `children()` accessor, a nested Loading/Errored/Show/For — are
created in the boundary's later flatten, after the window closed, so their
templates tried to claim server DOM the fallback replaced (key misses,
detached elements).

The boundary's owner is now marked when the content runs: `isClaiming` walks
the owner chain and claims nothing under a mark, whenever the node is
created. The served-answer check in readSerializedOrCompute asks about the
window alone, so reruns there keep re-serving. A nested Loading created
where nothing claims takes the unclaimed path and no longer waits on a
fragment the server dropped with the content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* test(hydration): the #4348 spec stubs _$HY as the real bootstrap does

The spec stubbed `_$HY.r` as a plain object, so the `inner` shape's
serialized promise, rejected by the stream before the memo under the content
exists, raised an unhandled rejection the real bootstrap never raises: its
`r` is a Proxy that catches every promise filed under it (#3769). A shared
helper, test/harness/hydration-bootstrap.ts, installs that global; the spec
uses it and runs `inner` streamed too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1079 branches covered (73.22%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

1124 of 1354 relevant lines covered (83.01%)

28.49 hits per line