solidjs / solid / 40701929161

78%

main: 89%

push

github

fix(signals): a latest()/isPending() reader born in a newly opened branch reads that branch's world (#4341) (#4352)

* fix(signals): a latest()/isPending() reader born in a newly opened branch reads that branch's world (#4341)

A memo created in a <Match> that a staged or held condition just opened,
reading latest() of an unrelated memo, threw "Attempting to access a stale
value from <Match>" and halted the reactive system. Entering a verdict
window made the memo's first pass a verdict reader, and a verdict reader
reads the screen (`frameRead`, `stagedScreen`). `bornInto` exempts a node
born into a transaction, but only once it is held, at the end of that same
pass. So the pass read the committed world, where its own branch was still
closed, and the <Match> accessor guard (`untrack(switchFunc)`) threw.

`markVerdictReader` now walks the passes still running above the reader
(its creator's, theirs). When one of them read the future or a staging,
the pass does not become a verdict reader yet. It takes those flags, so
`route` keeps it in its frame, and it reads that world like any derivation
of it. It is a verdict reader from its next pass (REACTIVE_PROBED, as
before). The walk is in verdict.ts, so apps without latest()/isPending()
ship nothing new. quietPending is golfed to offset the bytes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(signals): verdict reads test presence, not null, to pay for #4341

The size gate failed on the page scenarios once merged with next: the
#4341 walk cost +29 B minified on the live page and +66/+67 B on the
compiled live page and the live + router page. Those two split their
eager graph into an entry and a hoisted shared chunk (web.js), with
verdict.ts in the entry and core.ts and constants.ts in web.js. So the
walk's `creatorPass` reference and its unfolded REACTIVE_STAGED_READ
became two new cross-chunk import/export pairs, and th... (continued)

790 of 1078 branches covered (73.28%)

Branch coverage included in aggregate %.

1127 of 1357 relevant lines covered (83.05%)

28.47 hits per line