solidjs / solid / 40701911140

78%

main: 89%

push

github

fix(signals): a derive's peek at a reader of its own keys settles (#4342) (#4351)

A derived store's derive that peeks (untracked, NotReadyError caught) at a
memo built from its own leaves re-ran without bound after a parent key
change. The peek of a pending memo links it to the derive, and a leaf's
reader is linked to the derive by the flight it observed (`pullFamily`).
A held frame keeps both links after the passes that dropped them (A30). The
derive's commit woke every reader linked to it on every pass, so a reader
that builds a fresh object (a query key) re-ran the peeked memo, the memo
re-ran the derive, and the derive re-ran the reader, all in one flush,
until `queuePendingNode` threw a RangeError.

#4307 made the wake park the leaves' readers on the derive itself, so a
row's key is still pending when the derive's pass for the new parent key
peeks at it; before, the parent key's landing had released it. The same
loop predates #4307 when the peeked memo is pending on another source.

A sync pass now wakes the derive's readers only if the derive was pending
or errored before it; a landing wakes them as before (#4070). A settled
derive's links are stale ones from readers that re-ran since.


Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1078 branches covered (73.28%)

Branch coverage included in aggregate %.

1127 of 1357 relevant lines covered (83.05%)

28.53 hits per line