solidjs / solid / 40701895192

78%

main: 89%

push

github

fix(signals): an unread pending memo behind memos does not hold a verdict-mounted Loading (#4340) (#4350)

#4207 (#4203) kept a nested first pass left pending from joining a
verdict lane's mount through its staged read (REACTIVE_STAGED_READ), but
left REACTIVE_JOINED in the mask. A settled nested memo that reads the
mount's staging (`gate = createMemo(() => version())`) is born held, as
#4166 needs; a pending memo that reads `gate` then joins through
`joinPass` (a read of a held node), so the trailing pending-hold block
held it and the boundary caught it (`freshHook`), and `<Loading>` stayed
on its fallback forever though nothing reads that memo. Each further memo
between them only repeats the hop.

A nested first pass under a mount that is not a render effect and is left
pending now joins nothing, whatever it read: no render effect reaches it
yet, so it holds nothing and reaches no boundary (Reader). A render effect
that reads it goes pending and is caught on its own. A settled nested
memo, a render effect, and the mount's own first pass are held as before.
-1 B minified on the lane-engine scenarios.


Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Co-authored-by: Claude <noreply@anthropic.com>

790 of 1078 branches covered (73.28%)

Branch coverage included in aggregate %.

1127 of 1357 relevant lines covered (83.05%)

28.52 hits per line