kubevirt / containerized-data-importer / #6319

50%

main: 50%

Build Type

Pull #4327

travis-ci

Committed by aidanleuck

Commit Message

operator: render customizeComponents flags in a stable order

flagsToArray iterated over a map, so the order of the generated container
args was random. With two or more flags set in customizeComponents.flags the
operator rendered a different Deployment on (almost) every reconcile, which
kept updating the Deployment and rolling out new pods.

Sort the flags by name so the output is deterministic and add a test that
fails with the previous implementation.

Signed-off-by: Aidan Leuck <aidan@leucks.com>

Pull Request Pull Request #4327: operator: render customizeComponents flags in a stable order

Coverage Stats

10 of 10 new or added lines in 1 file covered. (100.0%)

11 existing lines in 1 file now uncovered.

15553 of 30920 relevant lines covered (50.3%)

0.56 hits per line