kubevirt / containerized-data-importer / #6314

50%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Add storage capabilities for rancher.io/local-path (#4319)

* Add storage capabilities for rancher.io/local-path

local-path-provisioner is the default provisioner in k3s and kind,
and the kind provider in cluster-up uses it for its default
StorageClass. It has no entry in CapabilitiesByProvisionerKey, so its
StorageProfiles get no claimPropertySets and the Recognized condition
is False with UnrecognizedProvisioner. A DataVolume that uses
spec.storage without accessModes on such a StorageClass then fails
with "no accessMode specified in StorageProfile".

local-path-provisioner only accepts ReadWriteOnce and ReadWriteOncePod
for node paths and always creates Filesystem PVs, so advertise
ReadWriteOnce with Filesystem.

Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>

* Share one capability helper for node-local path provisioners

hostpath-provisioner (CSI and legacy), minikube-hostpath and
local-path-provisioner all back a volume with a directory on one
node, so each of them only offers ReadWriteOnce Filesystem volumes.
Use a single createLocalPathCapabilities helper for them instead of
repeating the literal, as suggested in review.

Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>

* Drop redundant local-path unit tests

rancher.io/local-path only reuses createLocalPathCapabilities, which the
existing hostpath-provisioner tests already cover, so the extra reconcile
test and the recognized-provisioner table entry did not exercise any new
logic.

Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>
Assisted-by: Claude <noreply@anthropic.com>

---------

Signed-off-by: YoungjuKim <fjvbn2003@gmail.com>

Coverage Stats

0 of 3 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

15554 of 30912 relevant lines covered (50.32%)

0.56 hits per line