ArduPilot / MethodicConfigurator / 40635234146

94%

push

github

fix(compass): unlock navigation before showing calibration results

Compass calibration could finish with all progress bars green while
leaving the GUI blocked. The completion handler opened a modal result
dialog before destroying the borderless progress popup, keeping the
navigation lock held until the dialog was dismissed. An obscured dialog
could therefore prevent the user from continuing or cancelling.

Destroy the progress popup before displaying terminal result dialogs,
and parent those dialogs to the main window. Apply the same ordering
to successful completion, accepted cancellation, and calibration failure
when controller cancellation succeeds.

Let popup destruction stop polling and release navigation before dialog
creation, so a dialog error cannot leave the finished session locked.

Add regression coverage using real Tkinter windows and navigation
controls for:
- Completion through reports, individual status text, and generic status text
- Accepted cancellation and calibration failure
- Result dialog errors after session cleanup

Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>

7790 of 8922 branches covered (87.31%)

27710 of 29623 relevant lines covered (93.54%)

2.79 hits per line