kivy / pyobjus / 40585089860

72%

Build Type

push

github

Committed by web-flow

Commit Message

Accept str in char* arrays; raise TypeError for other types (#172)

* Accept str in char* arrays; raise TypeError for other types

CArray.as_char_ptr cast every element with an unchecked <bytes> cast, so a
str element (the normal string type on Python 3) reached PyBytes_AS_STRING
and aborted on its assertion, or would read the wrong memory without it.

Elements may now be str or bytes. str is encoded as UTF-8 and copied to
malloc'd memory that is intentionally not freed, since the Objective-C side
may keep the pointers after the call. bytes are used in place as before.
Anything else raises TypeError before any memory is allocated.

Add the first tests for char* arrays.

Coverage Stats

20 of 23 new or added lines in 1 file covered. (86.96%)

1 existing line in 1 file now uncovered.

1296 of 1860 relevant lines covered (69.68%)

0.7 hits per line