kubeflow / trainer / 40584057434
81%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 45
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 77.482%. Remained the same
40584057434

push

github

web-flow 
fix(api): validate OptimizationJob parameter names (#4062)

* fix(api): rebase OptimizationJob parameter validation on master

Retain upstream OptimizationJob webhook cases and generated API changes
while adding parameter name admission validation and regression coverage.

Signed-off-by: mimosapudical <153621177+mimosapudical@users.noreply.github.com>

* test(webhooks): consolidate OptimizationJob validation cases

Move parameter-name admission cases into the existing creation table
using the same error matchers; retain all 10 regression scenarios.

Signed-off-by: mimosapudical <153621177+mimosapudical@users.noreply.github.com>

* test(webhooks): inline OptimizationJob parameter validation entries

Follow the existing TrainJob DescribeTable style instead of using a
parameter-name closure factory; retain all validation cases.

Signed-off-by: mimosapudical <153621177+mimosapudical@users.noreply.github.com>

* test(webhooks): polish OptimizationJob parameter validation entries

Name valid and invalid cases consistently with the existing creation tests.
Default numTrials and parallelTrials to one in the OptimizationJob
wrapper, removing repeated overrides from the ten parameter test cases.

Signed-off-by: mimosapudical <153621177+mimosapudical@users.noreply.github.com>

---------

Signed-off-by: mimosapudical <153621177+mimosapudical@users.noreply.github.com>

3348 of 4321 relevant lines covered (77.48%)

0.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 40584057434.1 45
77.48
GitHub Action Run
Source Files on build 40584057434