kubeflow / trainer / 40575474965

81%

push

github

feat(controller): add TLS curve preferences to controller config (#4103)

Add TLS options (minVersion, cipherSuites, curvePreferences, nextProtos)
to the Trainer Configuration API and apply them uniformly to the metrics,
webhook, and status servers through a single tlsconfig.Apply entry point.

Values are validated at configuration load time so that unrecognized
versions, cipher suites, and curve IDs fail controller startup instead of
being silently ignored at serve time. RC4 suites are rejected outright
per RFC 7465. curvePreferences are numeric IANA Supported Group IDs;
Go ignores the list order and applies its own preference order.

Breaking change: configurations that v2.3.0 accepted with a startup
warning (unrecognized minVersion or cipher suite names, RC4 suites)
now fail validation and prevent the controller from starting.

Also deflake the status server key rotation authorization test.

Signed-off-by: Ugo Giordano <ugiordan@redhat.com>

60 of 60 new or added lines in 2 files covered. (100.0%)

3348 of 4321 relevant lines covered (77.48%)

0.78 hits per line