umputun / spot / 40543485473

85%

push

github

fail on an unreadable or unparsable env file (#373)

* fix: fail on an unparsable env file

envVars only logged a warning when the env file could not be parsed and the run went on
without any of its vars, so a typo in env.yml ran the playbook with empty values. A parse
error is now returned. A missing file is still skipped, and a file with no yaml document
(empty or comments only) still counts as no vars.

* fix: fail on an env file that cannot be opened

envVars treated every os.Open error as a missing env file, so an env.yml that exists but
cannot be read (permission denied) was skipped without a log line and the playbook ran with
empty values. Only a file that does not exist is skipped now; any other open error is
returned. TestEnvVars also checks that both error messages name the env file.

6 of 6 new or added lines in 1 file covered. (100.0%)

3481 of 4101 relevant lines covered (84.88%)

64.26 hits per line