hyperledger-labs / fabric-smart-client / 40418754579

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(comm): close sessions whose streams died (#2266)

A session whose streams all died now closes on its own, so a view waiting on Receive() after its counterparty crashed gets a closed channel instead of waiting for its own timer or forever.

When reading from a stream fails, handleIncoming removes the stream from every session holding it. A session left without a stream closes after a 5-second grace period, unless a send or a message from the remote attaches a new stream in the meantime. The session keeps one grace timer and restarts it each time it loses its last stream, so every loss gets the full period. The master session never closes this way. On libp2p all sessions to a peer share one stream, so a dead stream closes every session to that peer that neither sends nor receives within the grace period. Sessions used to prune their closed streams every five minutes; that ticker is removed, since dead streams no longer stay in sessions.

Endorsement collection returns an error when the session to an endorser closes while it waits for the reply, instead of dereferencing the nil message a closed Receive() channel yields.

The grace period is a session field set to sessionStreamGrace, which lets the tests use 100 ms. TestSession_ClosedWhenOnlyStreamDies, TestSession_SurvivesWhenReplacementStreamAttaches and TestSession_GraceRestartsWhenLastStreamDiesAgain cover closing, surviving through a replacement stream, and restarting the grace period.

A closed session stays in the node's session registry until its view context is disposed; #2271 tracks removing it.

Fixes #2178

Signed-off-by: Said Altury <Said.Altury@ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

32 of 34 new or added lines in 4 files covered. (94.12%)

4 existing lines in 2 files now uncovered.

30074 of 32910 relevant lines covered (91.38%)

1221.33 hits per line