supabase / supabase-flutter / 40336741954

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(auth)!: signOut must not report success when the server revoke was skipped or lost (#2053)

Fixes
[SDK-2374](https://linear.app/supabase/issue/SDK-2374/fixauth-signout-must-not-report-success-when-the-server-revoke-was).

`signOut` could return normally although the server never revoked
anything. Global and others sign out now throw and keep the session
instead of reporting success. A local sign out now waits for its revoke,
so `dispose()` can no longer abort it, and logs a failure instead of
throwing, since the app has no session left to retry with.

## Global and others sign out

When `getSession()` fails to refresh (429, a proxy page, an unknown
error code) the session is kept since #2033, and `signOut(scope: global
| others)` used to fall back to the stored, expired access token. GoTrue
answers `/logout` with 403 `bad_jwt` for it, which counted as "already
signed out", so the call succeeded while every other device stayed
signed in.

- When the refresh fails and the stored access token has expired,
`signOut` rethrows the refresh error and keeps the session. A token
still inside the expiry margin is used as before, but only if no other
sign in replaced the session meanwhile.
- When the refresh token was rejected, the failed refresh has already
signed this device out, but nothing was revoked on the server. `signOut`
used to return normally here. It now rethrows, so the other devices are
not silently left signed in.
- `_revokeSessions` used to ignore every 401, 403 and 404 from
`/logout`. GoTrue (checked against v2.197) answers an expired or forged
access token with 403 `bad_jwt`, and a session or user that is already
gone with 403 `session_not_found` or `user_not_found`. It now reads the
error code: only `session_not_found` and `user_not_found` count as
already signed out, so `bad_jwt` throws. For a server that answers
without an error code, a 404 still counts as signed out, and a 401 or
403 counts as signed out only when neither the message nor... (continued)

Coverage Stats

53 of 57 new or added lines in 1 file covered. (92.98%)

1 existing line in 1 file now uncovered.

12156 of 12923 relevant lines covered (94.06%)

6.34 hits per line