supabase / supabase-flutter / 40333345355

94%

Build Type

push

github

Committed by web-flow

Commit Message

perf(postgrest): stop wrapping every inserted and upserted row in a cast view (#2058)

Stacked on #2057.

Fixes
[SDK-2402](https://linear.app/supabase/issue/SDK-2402/perfpostgrest-stop-wrapping-every-inserted-and-upserted-row-in-a-cast).

## Summary

`_jsonRow`, which `insert()` and `upsert()` (and the typed
`insertAll`/`upsertAll`) use to turn each row of a list into a JSON
object, ended with `json.cast()`. `Map.cast` always returns a wrapping
view, even when the row already is a `Map<String, dynamic>`, so the key
check, the `columns` collection, `jsonEncode` and the copy of the body
to the encoding isolate all went through a type-checking view.

Rows that already are a `Map<String, dynamic>` are now returned as they
are. Other maps with only String keys are copied once with `Map.from`. A
row with a non-String key still throws `ArgumentError`.

Measured with a canned HTTP transport, AOT compiled, on macOS arm64:

| Insert, v3 default codec | Before | After |
| --- | --: | --: |
| 10000 rows, total | 10.78 ms | 8.25 ms |
| 10000 rows, longest main isolate stall | 5.42 ms | 2.59 ms |
| 1000 rows, total | 834 µs | 776 µs |

## Tests

`insert()` and `upsert()` of a list holding a `Map<dynamic, dynamic>`
and a `Map<String, Object?>` send the right body and `columns`
parameter, and a row with a non-String key throws.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
* Insert and upsert requests now correctly serialize rows provided as
maps with string keys, including maps using different value types.
  * Request columns are correctly included based on the row keys.
* Rows with non-string keys continue to be rejected with an
`ArgumentError`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

16 existing lines in 4 files now uncovered.

12127 of 12894 relevant lines covered (94.05%)

6.34 hits per line