IgniteUI / igniteui-webcomponents / 40292174405

100%

push

github

fix(select): keep the active item when the same value is set again (#2518)

- list selection: select() follows a property such as value. For the
  selected item it changes nothing and returns false, so it no longer
  moves the active item back to the selection. The new commit() is
  for user actions and method calls: it selects the item and makes it
  the active item, also when it is already selected. Before, each set
  of value moved the active item, so a framework that sets each
  property on each render, such as React, reset the keyboard position
  of an open list, and Enter could select the wrong item
- select: the value setter and the item change handler use select().
  A user selection, select() and clearSelection() use commit(), so
  they move the active item as before, and a closed ArrowDown after
  Escape does not stop on the selected item. The item change handler
  now also prunes when the value still matches, so an active item
  that is removed from an open list hands the navigation back to the
  selected item. Before, Enter could select the removed item
- dropdown: _selectItem() and clearSelection() use commit(), with no
  change in behavior
- spec: setting the same value or no value again keeps the active
  item, select() moves it, a removed active item, a commit of the
  selected item, and a click or select() on the selected item in the
  dropdown. Three tests fail without the fix, and three fail when
  commit() does not move the active item
- docs: CHANGELOG under Fixed, and the spec.md of the select and the
  dropdown

Closes #2515

8755 of 8853 branches covered (98.89%)

Branch coverage included in aggregate %.

33 of 34 new or added lines in 3 files covered. (97.06%)

53489 of 53622 relevant lines covered (99.75%)

3697.36 hits per line