IgniteUI / igniteui-webcomponents / 40287013100

100%

push

github

fix(button): forward the host aria-expanded, aria-haspopup and aria-controls (#2517)

- button, icon button: the host aria-expanded, aria-haspopup and
  aria-controls go to the native button, the link and the disabled
  link. Before, they stayed on the host, so a button that opens a
  menu, a panel or a drawer could not tell its state to assistive
  technology. aria-controls goes by element reference, because an
  IDREF does not cross the shadow boundary. An empty value and an
  aria-controls that references no element are not forwarded
- dropdown: the target gets aria-haspopup and aria-expanded only when
  the value changes. A button target renders again on each write,
  also of the same value, so with the fix it would render on each
  arrow key
- the fix also reaches the aria-haspopup and aria-expanded that the
  dropdown writes on a button target, and the aria-controls of the
  carousel navigation buttons
- spec: the state on a button, a link and a disabled link, after a
  change, a removal and each set of ariaControlsElements; empty
  values and a missing reference; the icon button; the native button
  of a dropdown target, with no target render on navigation; the
  carousel navigation buttons
- docs: CHANGELOG under Added, and the spec.md of the button, the
  dropdown and the carousel

Closes #2513

8751 of 8849 branches covered (98.89%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 2 files covered. (100.0%)

53483 of 53616 relevant lines covered (99.75%)

3697.1 hits per line