visgl / deck.gl / 40260917569

85%

push

github

fix(core): disable lighting in ShadowPass (#10890)

SimpleMeshLayer applies Phong lighting after DECKGL_FILTER_COLOR, where
the shadow module writes the RGBA-packed depth. In the shadow pass the
stored depth was therefore scaled by the lighting factor (0.77 with the
default material and a 45 degree light), and every lit SimpleMeshLayer
fell inside its own shadow. Disable the lighting module in the shadow
pass, as PickLayersPass already does.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

9858 of 12219 branches covered (80.68%)

Branch coverage included in aggregate %.

16314 of 18880 relevant lines covered (86.41%)

28116.88 hits per line