trickstercache / trickster / 40249168523

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(dpc): recover from timeseries cache unmarshaling failure (#1213)

When reading a cached timeseries from a non-chunking cache (such as
Redis), if the cached payload cannot be unmarshaled (e.g. legacy point
layout ErrLegacySeries or corrupted bytes), QueryCache was discarding
the unmarshal error and returning a partially-populated DataSet with
pre-populated ExtentList. This caused DeltaProxyCache to treat the entry
as a partial hit with phantom coverage, suppressing origin fetches and
returning empty results.

1. In dataset.UnmarshalDataSet and ReadDataSet, return (nil, err) on
   unmarshaling failure instead of returning a partially-populated DataSet.
2. In queryCache, propagate the unmarshaler error so that
   DeltaProxyCacheRequest detects the failure, purges the invalid cache entry
   via cache.Remove, and recovers by fetching fresh data from the origin.
3. Add TestDeltaProxyCacheUnmarshalingFailureRecovery regression test.

Signed-off-by: thinker0 <thinker0@gmail.com>
Co-authored-by: Gemini <noreply@google.com>

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

36 existing lines in 15 files now uncovered.

99094 of 105753 relevant lines covered (93.7%)

15613.66 hits per line