trickstercache / trickster / 40052759381

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(alb,tsm): skip timeseries unmarshaling for non-2xx gather responses (#1212)

* fix(alb,tsm): skip timeseries unmarshaling for non-2xx gather responses

When an ALB TSM pool member returns a non-2xx status code (e.g., 400 Bad Request
with error JSON), TSM was attempting to unmarshal the error payload as a timeseries
dataset via prepareGatherContribution. This caused spurious decode failure warnings
and prevented clean error propagation.

This change guards prepareGatherContribution with a 2xx check in both
serveStandard and collectPlanResult, ensuring non-2xx responses are treated
as failed member contributions without attempting timeseries unmarshaling.

Signed-off-by: thinker0 <thinker0@gmail.com>
Co-authored-by: Gemini <noreply@google.com>

* fix(alb,tsm): propagate error winner body and status when all fanouts fail

Address PR #1212 review feedback:
- Propagate error status code, headers, and body in both serveStandard and
  serveMultiVariantPlan when all fanouts/variants fail (no 2xx members).
- Gate rawBody and rawHeader clones behind !is2xx check in serveStandard
  and collectPlanResult to avoid allocating memory for healthy responses.
- Attach spy TSUnmarshaler directly to child fanout resources in unit
  tests to reliably verify that timeseries decoding is skipped.
- Add regression tests for mixed error responses (400 vs 502/504) and
  all-variant failure in serveMultiVariantPlan.

Signed-off-by: thinker0 <thinker0@gmail.com>
Co-authored-by: Gemini <noreply@google.com>

---------

Signed-off-by: thinker0 <thinker0@gmail.com>
Co-authored-by: Gemini <noreply@google.com>

Coverage Stats

109 of 134 new or added lines in 3 files covered. (81.34%)

30 existing lines in 9 files now uncovered.

99097 of 105749 relevant lines covered (93.71%)

15491.68 hits per line