karanshukla / vinoOpenEffects / 40223257014

62%

push

github

fix(config): write state.toml atomically and keep one that won't parse (#91)

save_to used fs::write, so a crash or full disk mid-save left a truncated
state.toml. The daemon then failed to parse it, fell back to defaults,
and its startup camera autodetect saved those defaults over the file
straight away. One bad write cost every setting.

- save_to writes state.toml.tmp, fsyncs it and renames it over the file
- AppState::load_or_recover moves a file that doesn't parse to
  state.toml.bad-<unix secs> before returning defaults; the daemon uses it
- tests for the failed-write, truncated, moved-aside and unknown-key cases

97 of 109 new or added lines in 2 files covered. (88.99%)

6662 of 11388 relevant lines covered (58.5%)

14597.15 hits per line