gookit / goutil / 40188095025

87%

Build Type

push

github

Committed by inhere

Commit Message

fix(maputil): support the bracket index on the top key of SetByPath

SetByKeys() short circuited a single key and the deep make, so a top key with
a slice index was written as a literal key:

  SetByPath(&mp, "list[1]", "b")
  // before: mp["list[1]"] = "b"
  // now:    mp["list"] = []string{"", "b"}

- route a key that contains a slice index into setMapByKeys(), which already
  knows how to update, grow and create the slice value. it also fixes a deep
  path like "list[0].name", which wrote the literal "list[0]" key too.
- a value that is not assignable to the slice elem type panicked with
  "reflect.Set: value of type ... is not assignable to type ...", it returns
  an error now and the data is left as it was. A nil value is turned into the
  zero value of the elem type, so it can be set to a nil-able elem type.

Tests: the top index key (update, append, create, deep path, negative index)
and the type mismatch for the top key, the index key and the nested bracket,
plus the nil value cases.

Coverage Stats

27 of 29 new or added lines in 1 file covered. (93.1%)

2 existing lines in 1 file now uncovered.

16106 of 18448 relevant lines covered (87.3%)

5.64 hits per line