gookit / goutil / 40157136773

87%

Build Type

push

github

Committed by inhere

Commit Message

fix(maputil): reject negative slice indexes when setting a value

The set path parsed the slice index with `strconv.Atoi` and dropped the error,
so a negative index panicked instead of returning an error - the same bug that
#294 fixed on the get side:

  maputil.SetByPath(&mp, "list.-1", "x")   // panic: reflect: slice index out of range
  maputil.SetByPath(&mp, "app.list[-1]", "x") // same, bracket syntax
  maputil.MakeByPath("tags[-1]", "v")      // same, when it makes the slice value

- add parseIndexKey(), which rejects a non-numeric and a negative index, and
  use it at the three places that read an index from the key path
- setMapByKeys() returns an error for a negative bracket index instead of
  slicing with it, so the map data is left unchanged
- MakeByKeys() keeps a negative index as a literal key, it can not return an
  error

The Config.Set() of gookit/config goes through maputil.SetByKeys(), so it
inherits the fix as well.

Tests: the negative index key, the bracket syntax and MakeByPath cases, plus a
positive case for an index key, the bracket syntax and a grown slice.

Coverage Stats

16 of 22 new or added lines in 2 files covered. (72.73%)

1 existing line in 1 file now uncovered.

16087 of 18425 relevant lines covered (87.31%)

5.64 hits per line