eclipse-aascw / aas-core-codegen / 40140041326

90%

push

github

Trace JSON values in tests of all targets (#865)

We type-check the generated Python tests with mypy 2.4.0 as the SDKs do,
and found that they pass a JSON-able value to ``tests.common.trace``,
which accepts none. We now trace these values as their JSON text:

    def trace_json(that: our_types.JsonValue) -> str:
        return json.dumps(that, sort_keys=True)

The ``over_X_or_empty`` and ``X_or_default`` tests call it on the JSON
items at any depth. The ``trace`` now accepts nested sequences through
a recursive alias ``Traceable``, which mypy 2.4.0 needs for the nested
collections. The live test and the fast check run mypy on
``dev/tests``, too.

We extend the meta-model ``json_types_in_collections`` with an optional
list of JSON objects and an ``optional_object_or_default`` method. This
uncovered the same gap in the tests of the other targets, which we fix
as well: C++ dumps the ``nlohmann::json``, C# and Java convert a JSON
node in ``CommonJson``, Go stringifies maps, floats and slice items, and
TypeScript stringifies the JSON with the keys sorted.

The TypeScript serialization of a ``List[JSONObject]`` did not compile,
since ``jsonValueToJsonable`` returned a ``JsonValue``. We keep
``Array<JsonObject>`` and tell the compiler with overloads that the copy
keeps the shape:

    function jsonValueToJsonable(that: OurTypes.JsonObject): JsonObject;

38 of 43 new or added lines in 5 files covered. (88.37%)

46373 of 51405 relevant lines covered (90.21%)

2.71 hits per line