DigitalTolk / ex / 40085427737

100%

Build Type

push

github

Committed by web-flow

Commit Message

importer: count thread replies with consistent reads when finalizing (#341)

FinalizeParent read each thread's root with GetItem and its replies through
the thread index (GSI1). Both are eventually consistent, and GSI reads can't
be made consistent, so finalizing right after a bulk PutMessages could miss
replies written moments before: the root got too low a reply count, or was
reported missing. An import of a 327-message channel left 130 threads with
a wrong count.

FinalizeParent now reads the parent's partition once with ConsistentRead
(new MessageStore.ListParentMessagesConsistent) and takes each touched
root and its replies from that. Reply counts keep their meaning (every
reply row under the root, as the index listed them). One partition read
per call replaces two reads per thread.

Coverage Stats

11723 of 11723 branches covered (100.0%)

Branch coverage included in aggregate %.

62 of 62 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

50094 of 50098 relevant lines covered (99.99%)

1797.71 hits per line