ruby-grape / grape / 40075496335

100%

push

github

Add a setting to let an exception raised in a rescue_from block propagate (#3040)

Since #2703, Grape redispatches an exception raised inside a rescue_from
block, so it no longer reaches Rack middleware mounted above Grape. That
fixed #2482, and it also stopped a block from handing an exception to
such middleware by re-raising it. Active Record's DatabaseSelector with
a custom resolver that retries a request on the primary after an
ActiveRecord::ReadOnlyError is one: an API that re-raised the error from
rescue_from :all for it now answers 500 where the request used to
recover.

Grape.config.raise_rescue_handler_errors brings back the earlier
behaviour, as raise_rendering_errors (#2840) does for rendering
failures. With it on, whatever a rescue_from block raises is re-raised
untouched. A block that calls error! still renders, because Halt is
rescued ahead of it. Off by default.

Fixes #3003.

1521 of 1523 branches covered (99.87%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

4538 of 4539 relevant lines covered (99.98%)

30534.65 hits per line