supabase / supabase-flutter / 39977567655

93%

push

github

fix(supabase_test)!: fast failures, clock-aware sessions, a real signedIn event and stubs that match what the SDK sends (#2035)

Linear:
https://linear.app/supabase/issue/SDK-2357/fixsupabase-test-fast-failures-clock-aware-sessions-a-real-signedin

Fixes the twelve `supabase_test` findings from the v3 review. Each one
has a regression test in the package suite.

## Changes

1. **Fast failures.** `testSupabaseClient` turns off retries for
database requests and token refreshes by default, and takes a
`retryOptions` parameter to turn them back on. Auth sign-in calls were
never retried. `initializeTestSupabase` in
`supabase_flutter/testing.dart` gets the same default and parameter,
because its docs promise the same defaults as `testSupabaseClient`.
2. **`stubError` docs.** The example now says what happens: every failed
attempt counts against `times`, retries included. Retries are off in
`testSupabaseClient`, so each read fails until `times` runs out.
3. **Unmatched requests fail the test.** An unmatched request still
throws the `StateError`, and it is now also reported to the current zone
as an uncaught error. That fails the test even when auth or functions
wrap the error as a `SupabaseTransportException`. A test that expects an
unmatched request to fail can pass
`MockSupabaseHttpClient(reportUnmatchedRequests: false)`.
4. **Clock-aware sessions.** `signInTestUser` and the session stubs read
expiry from `clock.now()`. The stubs build the session when the request
arrives, so `withClock` and fake async clocks apply.
5. **Near-future `expiresAt`.** `signInTestUser` no longer goes through
`recoverSession`, so the 30 second expiry margin no longer applies. Only
an `expiresAt` that falls in the past once truncated to the whole
seconds of the `exp` claim is rejected, with an `ArgumentError`.
6. **`signedIn` event.** A new `@internal` method,
`AuthClient.signInWithSession`, stores the session and emits `signedIn`.
`signInTestUser` uses it.
7. **`verifyOTP` stub.... (continued)

96 of 99 new or added lines in 7 files covered. (96.97%)

11807 of 12745 relevant lines covered (92.64%)

6.16 hits per line