supabase / supabase-flutter / 39974612774

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix(supabase_flutter)!: keep cold-start auth links and make initialize safe against concurrent calls and dispose (#2034)

Fixes
[SDK-2352](https://linear.app/supabase/issue/SDK-2352/fixsupabase-flutter-cold-start-deep-links-can-be-lost-and-initialize).

## Changes

1. **Cold-start auth links are no longer lost.** `app_links` sends the
link that launched the app only to the first listener of its link
stream. `SupabaseAuth` now subscribes before waiting for the session
restore and holds back incoming links until the restore is done. It also
reads `getInitialLink` explicitly, so the link is exchanged even when
the app subscribed first. A launch link delivered both ways is exchanged
once. A link the `detectSessionInUriPredicate` throws for is logged and
skipped, so it cannot hold back later links.
2. **A concurrent `Supabase.initialize` waits for the first one.** Every
call gets the pending future, so a second call no longer returns a
half-ready instance. A call with another `url` or `publishableKey` fails
with a `StateError`. A failed initialization that never created a client
is forgotten, so the next call tries again.
3. **`dispose` during `initialize` leaks nothing.**
`SupabaseAuth.initialize` stops after the session restore when it was
disposed, and the link subscription it opened early is cancelled by
`dispose`.
4. **`WidgetsFlutterBinding.ensureInitialized()` is called
unconditionally**, so a custom `asyncStorage` no longer breaks the
`AppLifecycleListener` setup.
5. **The launch link is handled the same way on every platform.** It is
exchanged right after `initialize` completes, on web as well as on
mobile. This is documented on `Supabase.initialize` and in
`MIGRATION.md`.
6. **`signInWithSSO` takes `authScreenLaunchMode`**, the name
`signInWithOAuth` and `linkIdentity` use.
7. **`initializeTestSupabase` throws when an earlier instance was not
disposed**, instead of returning it with the earlier test's mocks. It
checks a new `@internal` getter, `S... (continued)

Coverage Stats

54 of 59 new or added lines in 3 files covered. (91.53%)

1 existing line in 1 file now uncovered.

11729 of 12667 relevant lines covered (92.59%)

6.19 hits per line