supabase / supabase-flutter / 39964070468

94%

push

github

fix(typegen)!: stop renaming generated types that clash with supabase_flutter and Flutter names (#2047)

Fixes
[SDK-2372](https://linear.app/supabase/issue/SDK-2372/fixtypegen-stop-renaming-generated-types-that-clash-with-supabase).

#2044 gave a generated table or enum named like a type of
`supabase_flutter` or the Flutter material and cupertino libraries a
`Table` or `Enum` suffix, so `user` became `UserTable`. The generated
file never imports those libraries, so the clash only happens in the
app's own file, where `as` or `hide` resolves it in one line. The list
made generated names hard to predict, could never be complete, and every
new entry would have been a breaking rename.

## Changes

- Removes `sdk_type_names.dart` and the `Table`, `Enum`, `ResultRow` and
`Result` fallbacks in `_TypeNameRegistry`. `user` is `User` again,
`session` is `Session`.
- Keeps the registry's set of names the generated file references
unqualified (`String`, `List`, `DateTime`, `PostgrestTable`, ...), which
still get `$`.
- Drops the suffix from the README and the generate skill.
- Regenerates the goldens. The hostile fixture's `badge` table is
`Badge` again, which #2046 had renamed to `BadgeTable`, and the tests
that use it follow. The schema golden only picks up the 0.6.0 version
header.

## Breaking

Tables, enums and function result rows named like one of the listed
types lose their suffix. No MIGRATION.md section, since
`supabase_typegen` is new in v3.

5 of 5 new or added lines in 1 file covered. (100.0%)

11522 of 12487 relevant lines covered (92.27%)

5.81 hits per line