IgniteUI / igniteui-webcomponents / 39961289760

100%

push

github

fix(chat): open only links to another origin in a new tab (#2500)

* fix(chat): open only links to another origin in a new tab

- markdown renderer: an http or https link to another origin opens in
  a new tab, with rel="noopener noreferrer". A link in the same
  origin, such as /register or #top, and a link such as mailto: open
  in the same tab, so the app can route them. Before, each link
  opened in a new tab, so an assistant that linked to pages of its
  own app opened the app again
- origin: the renderer compares the link with the global origin, so
  a srcdoc or about:blank frame uses the origin of its page. There,
  location.origin is "null"
- sanitizer: the default DOMPurify hook also removes target from a
  link in the same origin, so the HTML cannot choose the window. A
  custom sanitizer gets the attributes on Markdown links only, as the
  sanitizer JSDoc now says. For a custom sanitizer, the renderer reads
  the href as the browser decodes it. Before, it read the Markdown
  text, so a link written as https:// to another origin opened
  in the same tab
- spec: links in the same origin, http links, image map areas, a
  srcdoc frame, a target that the app's DOMPurify config keeps, and
  hrefs with character references or a backslash for a custom
  sanitizer. Each test fails without its fix
- docs: CHANGELOG, under Fixed for the default sanitizer and under
  Changed for a custom sanitizer

* test(chat): stub the global origin instead of a srcdoc frame

- spec: the global origin test stubs globalThis.origin. Before, it
  loaded a second copy of the renderer module in a srcdoc frame, and
  wtr kept only the coverage of that copy. So the coverage of
  chat-markdown-renderer.ts fell to 224 of 390 lines, and the total
  line coverage fell by 0.31%
- spec: the same-tab test also has an href that cannot be parsed
- coverage: the renderer is now at 384 of 390 lines, and the total
  is 99.752%

8744 of 8842 branches covered (98.89%)

Branch coverage included in aggregate %.

57 of 59 new or added lines in 1 file covered. (96.61%)

53465 of 53598 relevant lines covered (99.75%)

3694.68 hits per line