decentraland / atlas-server / 39957915429

94%

master: 94%

Pull #156

github

fix: render map images from the snapshot their etag names

The version was read when a request arrived but the render job read the
tiles later, once a thread freed, and the estate route read its version
after awaiting the tiles, so a map refresh in between paired an image
with the wrong ETag. Overlays also compared listings against the clock,
so one overlay version could map to two images.

- The map exposes getSnapshot(): the served tiles with their land and
  overlay versions, captured together. Records are swapped, never
  changed, so a held snapshot stays consistent.
- Each PNG request takes the snapshot once, before any await, and its
  version, cache key, estate lookup and render job all read from it.
- The image and minimap job builders take the tiles they draw, and the
  overlays are drawn from the data alone: expired listings are dropped
  by the map on every refresh.

1721 of 1873 branches covered (91.88%)

Branch coverage included in aggregate %.

790 of 797 new or added lines in 16 files covered. (99.12%)

5586 of 5917 relevant lines covered (94.41%)

2215.8 hits per line