decentraland / atlas-server / 39885013105

93%

master: 94%

Pull #155

github

fix: count render failures and test the pool's thread lifecycle

Worker crashes mid-render (e.g. out of memory under resourceLimits) were
only logged. Every failure path now increments
dcl_map_render_errors_total{kind, reason}, with reason one of busy,
aborted, prepare, transport, worker_error or worker_crash. A warm-up that
fails now tears the pool down before start() rejects.

Tests check the warm thread deterministically (one thread that already
ran a task) instead of timing the first render. They also cover a failing
warm-up, a thread dying mid-render (the next render runs on a replacement
thread) and RenderFailedError mapping to a 500.

1457 of 1608 branches covered (90.61%)

Branch coverage included in aggregate %.

766 of 813 new or added lines in 16 files covered. (94.22%)

5013 of 5340 relevant lines covered (93.88%)

2016.42 hits per line